Moq seems a good mocking library for .Net unit tests. It has most of the features a developer needs and pretty much stable and many people are using it. Once I started using it, I never felt a need to another mocking library. Below is one if the scenario which I had to face related to Moq.
At least make sure, there is some level of randomness in the selection of IMonkeys. Also we can make sure if there are 3 IMonkeys in the collection at least one of the IMonkey's unleash is called. If that is not called or called multiple times, there are some problems in the random selection logic of MonkeyKeeper.Unleash. Whats the problem in doing that?
We have 3 monkeys and we don't know which one will be selected by random logic. But we need to make sure that the unleash is called only once and on one monkey. This clearly tells that normal mechanism of asserting via Verify() and Times will not work. If there is any confusion just try writing that as below
Why the above wont work? when we unleash it may call mockMonkey1. and that line works and test passed. But what about the next lines? They will fail. We cannot put a return statement because next time mockMonket3 might be the one selected. In that case first 2 statements will fail.
Scenario
There is a method which randomly executes operations (IOperation implemented classes) stored in an array. The operations are unit tested independently to make sure there is no problems with them. This method which is in test simply uses Random class to get random number and get an operation from array using that number and invokes the operation.
Ideally speaking we don't need to test the Random class which is part of .Net framework. But why should we avoid unit testing our logic inside the method ? Some tests like 'making sure random value is not above the length of array' etc... So whats the big deal?
Challenge
The unit tests works by Arrange,Act,Assert methodology. First we need to arrange the things, Then act or do the operation by calling the method under test. Finally assert.
When we do the act, we should be knowing what is the output. Then only we can write assert. If we don't know what is going to happen we don't know what to assert.
An Example
Recently I forked ChaosMonkey for .Net and started contributing to it. I made it configurable. Looking into that code might be useful to understand the example better.It contains a MonkeyKeeper and IMonkey interface. MonkeyKeeper is the external interface. When MonkeyKeeper.Unleash() is called it should randomly pick an IMonkey from its monkeys collection and call Unleash() method on it. IMonkey implementations can be easily unit tested to make sure they are doing their duties on Unleash. But how to unit test MonkeyKeeper.Unleash()?
In this scenario, we can assert that the mocked IMonkey objects at least got one call to unleash. But in order to get at least one random calls, we need to call the MonkeyKeeper.Unleash multiple times because Random can return same value multiple times.
Below is one implementation, where MonkeyKeeper.Unleash() is called 5 times which is holding 3 IMonkeys collection.
Most of the times this test will succeed. But there is no guarantee that it will succeed always because Randon.Next() using inside MonkeyKeeper.Unleash can return same value 4 times and that's why its random. in such scenarios this test will fail. So whats the solution.
Below is one implementation, where MonkeyKeeper.Unleash() is called 5 times which is holding 3 IMonkeys collection.
[TestMethod] public void WhenMonkeyListProviderGivesMultipleMonkeysAndUnleashMultipleTimes_UseThoseMonkeysAtleastOnce() { Settings settings = new Settings(); ChaosLogger logger = new ChaosLogger(""); //Arrange var mockMonkey1 = new Mock<ParentMonkey>(settings, logger); var mockMonkey2 = new Mock<ParentMonkey>(settings, logger); var mockMonkey3 = new Mock<ParentMonkey>(settings, logger); var mockMonkeyListBuilder = new Mock<MonkeyListBuilder>(); mockMonkeyListBuilder.Setup(builder => builder.GetMonkeys(settings, logger)) .Returns(new List<ParentMonkey>() { mockMonkey1.Object, mockMonkey2.Object, mockMonkey3.Object }); MonkeyKeeper keeper = new MonkeyKeeper( settings, logger, mockMonkeyListBuilder.Object); //Act keeper.UnleashRandomMonkey(); keeper.UnleashRandomMonkey(); keeper.UnleashRandomMonkey(); keeper.UnleashRandomMonkey(); keeper.UnleashRandomMonkey(); //Assert mockMonkey1.Verify(monkey => monkey.Unleash(), Times.AtLeastOnce); mockMonkey2.Verify(monkey => monkey.Unleash(), Times.AtLeastOnce); mockMonkey3.Verify(monkey => monkey.Unleash(), Times.AtLeastOnce); }
Most of the times this test will succeed. But there is no guarantee that it will succeed always because Randon.Next() using inside MonkeyKeeper.Unleash can return same value 4 times and that's why its random. in such scenarios this test will fail. So whats the solution.
Solution
There is no solution to this. If we can predict random number and write asserts, that is not random. So what we can do?At least make sure, there is some level of randomness in the selection of IMonkeys. Also we can make sure if there are 3 IMonkeys in the collection at least one of the IMonkey's unleash is called. If that is not called or called multiple times, there are some problems in the random selection logic of MonkeyKeeper.Unleash. Whats the problem in doing that?
We have 3 monkeys and we don't know which one will be selected by random logic. But we need to make sure that the unleash is called only once and on one monkey. This clearly tells that normal mechanism of asserting via Verify() and Times will not work. If there is any confusion just try writing that as below
mockMonkey1.Verify(monkey => monkey.Unleash(), Times.AtLeastOnce); mockMonkey2.Verify(monkey => monkey.Unleash(), Times.AtLeastOnce); mockMonkey3.Verify(monkey => monkey.Unleash(), Times.AtLeastOnce);
Why the above wont work? when we unleash it may call mockMonkey1. and that line works and test passed. But what about the next lines? They will fail. We cannot put a return statement because next time mockMonket3 might be the one selected. In that case first 2 statements will fail.
Now whats the method? We need to know the number of times a method is called on mocked object. There is no direct way to know that. So we need to use the callback mechanism available in Moq to achieve our aim. Callback function helps to get a hook in our unit test when a particular method is called on mock object. Code goes as below.
http://stackoverflow.com/questions/16693078/when-using-moq-verify-method-invocation-count-have-failing-tests-error-messa
[TestMethod] public void WhenMonkeyListProviderGives3MonkeysAndUnleashOnce_UnleashMustBeCalledOnOneMonkey() { Settings settings = new Settings(); ChaosLogger logger = new ChaosLogger(""); //Arrange var mockMonkey1 = new Mock<ParentMonkey>(settings, logger); var mockMonkey2 = new Mock<ParentMonkey>(settings, logger); var mockMonkey3 = new Mock<ParentMonkey>(settings, logger); int callCount = 0; mockMonkey1.Setup(monkey => monkey.Unleash()).Callback(() =>callCount+=1); mockMonkey2.Setup(monkey => monkey.Unleash()).Callback(() => callCount += 1); mockMonkey3.Setup(monkey => monkey.Unleash()).Callback(() => callCount += 1); var mockMonkeyListBuilder = new Mock<MonkeyListBuilder>(); mockMonkeyListBuilder.Setup(builder => builder.GetMonkeys(settings, logger)) .Returns(new List<ParentMonkey>() { mockMonkey1.Object, mockMonkey2.Object, mockMonkey3.Object }); MonkeyKeeper keeper = new MonkeyKeeper( settings, logger, mockMonkeyListBuilder.Object); //Act keeper.UnleashRandomMonkey(); //Assert Assert.AreEqual(1, callCount, "Unleash Called multiple times"); }
http://stackoverflow.com/questions/16693078/when-using-moq-verify-method-invocation-count-have-failing-tests-error-messa
